-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builtin): generate @npm//foo__all_files
filegroup that includes all files in the npm package
#1600
feat(builtin): generate @npm//foo__all_files
filegroup that includes all files in the npm package
#1600
Conversation
0b7adc2
to
1c971c3
Compare
@npm//foo__raw_files
filegroup that includes all files in the npm package@npm//foo__all_files
filegroup that includes all files in the npm package
1c971c3
to
b884149
Compare
…all files in the npm package Including files with spaces & unicode characters & files that have been filtered out by the `included_files` attribute. This filegroup cannot be used in runfiles because of Bazel issue bazelbuild/bazel#4327, but it can be used for other purposes such as the srcs input to a pkg_tar for generating a tar of an npm package pulled down with yarn_install or npm_install.
b884149
to
5bddfa2
Compare
@@ -13,7 +13,6 @@ filegroup( | |||
"//:node_modules/rxjs/InnerSubscriber.d.ts", | |||
"//:node_modules/rxjs/InnerSubscriber.js", | |||
"//:node_modules/rxjs/InnerSubscriber.js.map", | |||
"//:node_modules/rxjs/LICENSE.txt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's technically a breaking change if users referred to one of these target directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. No breaking change here. This is just testing that the include_files
works are intended and that any files that aren't included still end up the __all_files target.
// of package files that end with `.umd.js`, `.ngfactory.js` and `.ngsummary.js`. | ||
// TODO(gmagolan): add UMD & AMD scripts to scripts even if not an APF package _but_ only if they | ||
// are named? | ||
const namedSources = isNgApfPackage(pkg) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so many changes in this file - I'm assuming it's just a refactoring moving lines around, and not this many lines edited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Some refactoring here.
Including files with spaces & unicode characters & files that have been filtered out by the
included_files
attribute. This filegroup cannot be used in runfiles because of Bazel issue bazelbuild/bazel#4327, but it can be used for other purposes such as the srcs input to a pkg_tar for generating a tar of an npm package pulled down with yarn_install or npm_install.Needed for angular/angular#33927 where pkg_tar is used to make a tar.gz of node_modules/puppeteer and on OSX the downloaded Chrome libs have spaces in their names:
See angular/angular#33927 (comment) for more details.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information